Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx: Remove superfluous arg to __bp_set_ret_value #139

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glensc
Copy link

@glensc glensc commented Feb 15, 2023

__bp_set_ret_value() takes just one argument:

__bp_set_ret_value takes just one argument
@glensc
Copy link
Author

glensc commented Feb 15, 2023

Seems it's trickery to set $_:

perhaps it then needs better code documentation, i.e for __bp_set_ret_value() function.

@glensc glensc marked this pull request as draft February 15, 2023 23:22
@rcaloras
Copy link
Owner

@glensc, thanks for submitting the PR.

Seems it's trickery to set $:
Yes, it effectively propagates the $
variable so it can continue to be used. Feel free to close the PR or edit the the comments if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants