Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-browser error #85

Open
code-elf opened this issue Dec 23, 2017 · 1 comment
Open

Cross-browser error #85

code-elf opened this issue Dec 23, 2017 · 1 comment

Comments

@code-elf
Copy link

code-elf commented Dec 23, 2017 •
edited
Loading

In 0.1.5, the function GenRandomBytes was changed - instead of writing an array into a variable, passing it as a parameter to crypto.getRandomValues and then returning that variable, it now returns the return value of crypto.getRandomValues directly.
According to the TS lib declaration file, this is correct - but I have found that on certain older browsers (such as the Android browser) crypto.getRandomValues returns no value and only mutates the parameter. Since version 0.1.5, this library therefore causes a TypeError on these browsers.
I would like to request the change to GenRandomBytes be reverted in the interest of cross-browser compatibility.
@elmarti
Copy link

elmarti commented May 31, 2018

This appears to have been fixed in this PR. 822def6 Would be nice if this was merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elmarti @code-elf