Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .scalafmt #4

Open
3 tasks
aaabramov opened this issue Nov 23, 2019 · 3 comments
Open
3 tasks

Add .scalafmt #4

aaabramov opened this issue Nov 23, 2019 · 3 comments

Comments

@aaabramov
Copy link
Collaborator

If we would like to support and enhance this library it would be nice to have common code style.
Moreover, Influx 2.0 is about to be GA (currently it is in Alpha), so there will be new features.

We can start from simplest cats config and improve it with the time.

  • Add .scalafmt
  • Add ci check for code formatting
  • Add contribution notice about code formatting
@razem-io
Copy link
Owner

@aaabramov sounds good. I never really used .scalafmt because it was a problem with one of our devs. However it really makes sense because this is an open source project and we need to have some kind of contribution guide.
Do you like a code style config best?

@aaabramov
Copy link
Collaborator Author

I will make a PR with code style changes.

Also, @razem-io could you add me as a write member of this library so that I can contribute here directly instead of proposing changes via fork?

@razem-io
Copy link
Owner

@aaabramov perfect, thank you. I added you as a contributer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants