Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Introduce default function for Helm additionalWorkerGroups containerEnv in ray-cluster helm chart #2569

Open
2 tasks done
TessaIO opened this issue Nov 26, 2024 · 0 comments · May be fixed by #2570
Open
2 tasks done
Assignees
Labels
enhancement New feature or request Helm Tracks improvements to Helm support

Comments

@TessaIO
Copy link

TessaIO commented Nov 26, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

When deploying this Helm chart using Terraform, we should set an empty list for the containerEnv on the additionalWorkerGroups level. While it's possible to do it using Terraform set_list, it will actually insert an empty string in the array, and the expected format should be an object.
To avoid this chain of problems, it would be nice to wrap containerEnv with a default function that returns an empty array.

Use case

We are deploying ray-cluster Helm chart using Terraform and specifying additionalWorkerGroups without specifying any containerEnv.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@TessaIO TessaIO added enhancement New feature or request triage labels Nov 26, 2024
@TessaIO TessaIO closed this as completed Nov 27, 2024
@TessaIO TessaIO reopened this Nov 27, 2024
@kevin85421 kevin85421 added Helm Tracks improvements to Helm support and removed triage labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Helm Tracks improvements to Helm support
Projects
None yet
2 participants