Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Controller Expectation #2566

Open
1 of 2 tasks
kevin85421 opened this issue Nov 25, 2024 · 0 comments
Open
1 of 2 tasks

[Umbrella] Controller Expectation #2566

kevin85421 opened this issue Nov 25, 2024 · 0 comments
Labels
1.3.0 enhancement New feature or request stability Pertains to basic infrastructure stability

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 25, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

  1. We store rayPod in the indexer, whereas ReplicaSet only stores an integer, which is more memory-efficient. We can run some benchmarks after this PR is merged to check for any memory issues. If so, we can switch to ReplicaSet's implementation.
  2. There might be some corner cases for suspend. Maybe we can only call deleteAllPods when there are no in-flight requests (i.e. expectation is satisfied).
  3. Possible memory leak if KubeRay misses the resource event.
  • TODO: Run chaos tests with chaos mesh or krkn.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage 1.3.0 stability Pertains to basic infrastructure stability and removed triage labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.3.0 enhancement New feature or request stability Pertains to basic infrastructure stability
Projects
None yet
Development

No branches or pull requests

1 participant