Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RayService][Refactor] ServeConfigs memory leak #2549

Open
1 of 2 tasks
Tracked by #2548
kevin85421 opened this issue Nov 17, 2024 · 0 comments
Open
1 of 2 tasks
Tracked by #2548

[RayService][Refactor] ServeConfigs memory leak #2549

kevin85421 opened this issue Nov 17, 2024 · 0 comments
Assignees
Labels

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 17, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

ServeConfigs cmap.ConcurrentMap[string, string]

ServeConfigs is used to determine whether the RayService controller should send a request to the Ray head to create or update Ray Serve applications. However, the key in the map is not removed after the RayService CR is deleted, causing a memory leak.

Possible solutions:

  1. Add a finalizer to the RayService CR, clean up the cache, and then remove the finalizer.
  2. Use an LRU cache.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage labels Nov 17, 2024
@kevin85421 kevin85421 changed the title [RayService][Refactor] ServeConfigs [RayService][Refactor] ServeConfigs memory leak Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants