[pull] main from aws:main #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…103) * Update version v1.5.1 in manifest, changelog and doxygen * Update version v1.5.1 in source and header files * Update version v1.5.1 in test cmakefile
Per the AWS documentation the 'ExpectedVersion' field is optional in an update msg for a job. This changes makes the expected version field optional. https://docs.aws.amazon.com/iot/latest/apireference/API_iot-jobs-data_UpdateJobExecution.html#iot-iot-jobs-data_UpdateJobExecution-request-status
* Feat: Support StatusDetails messaging in Update Message Allows users to send a valid JSON key-value set to the jobs service. This API does lightweight validation of the status details payload.
The upcoming CBMC version 6 release includes changes that may affect existing proofs. This PR will make sure that Jobs-for-AWS-IoT-embedded-sdk PRs are not negatively impacted by this release. After releasing CBMC version 6 we will issue a follow-up PR that will return Jobs-for-AWS-IoT-embedded-sdk to using CBMC's latest release, and will include any changes to proofs that may be necessary to support the new version.
Jobs_UpdateMsg was putting double quotes around the `statusDetails`
value resulting in the following invalid JSON:
```
{
"status": "QUEUED",
"statusDetails": "{
"key": "value"
}"
}
```
This change removes the unnecessary double quotes to generate a valid
JSON:
```
{
"status": "QUEUED",
"statusDetails": {
"key": "value"
}
}
```
This was reported here - #107
Signed-off-by: Gaurav Aggarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )