Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only polish language #188

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Only polish language #188

wants to merge 9 commits into from

Conversation

SHypoleac
Copy link
Contributor

I think this is not up for discussion, if you prefer to leave this mod untranslated then so be it. The Polish, however, is checked by me and corrected literally in a couple of places, because the rest is translated perfectly. If I encounter any errors in this translation in the game I will still polish it up.

I took the .properties files from Italian,Russian and Spanish. Compared them and created set of english sentences, deleting their translation. Later i just passed it by my translating program and I corrected some mistakes. I think that there could be some polish players who will like this work. It looks like this is the best mod for Unciv worldwide :D
@SeventhM
Copy link
Collaborator

2 notes

  1. A helpful trick when using git is to never edit on your master branch. You should general edit on a separate branch and PR to whatever you're contributing to from there. That would help avoid needing all of the merges from this master showing up in your PRs
  2. I'm hesitant to accept this. I won't close it immediately, but I *will* require you get a native Polish speaker confirm this PR. Until then, I won't accept. If you want a polish speaker, you could always see about asking the one that edits for Unciv itself

@SHypoleac
Copy link
Contributor Author

SHypoleac commented Apr 17, 2024

I have lived in Poland all my life and know my language :) Personally, I have already translated the basic version of the game.
I thought that instead of creating my own mod, I would add something to the existing one, but I guess I got it wrong since you are afraid to even add a translation.
btw Thanks for advice
Can I just copy all this stuff and start adding my own content to it, creating another mod ?

@SeventhM
Copy link
Collaborator

Sure, go ahead, I don't have the power to care about any mod you make based on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants