Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump-up tsa + e2e (CLI + K8S) #1685

Conversation

junczhu
Copy link
Collaborator

@junczhu junczhu commented Aug 5, 2024

Description

What this PR does / why we need it:

Which issue(s) this PR fixes *(optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged) *:

This is heading a new PoC branch and ready to merge
Bump-up notation-go and add timestamp, including related e2e tests
Reference: https://hackmd.io/CR_XKZsMSvyjjxU6fOqdcw?both

Bump-up: notation verifier dependency
Reference: https://github.com/ratify-project/ratify/pull/1685/checks?check_run_id=29115851961

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • e2e: CLI - using valid cert, setting trust policy to always verify tsa signature
  • e2e: CLI - using exp cert and setting trust policy to verify afterCertExpired
  • e2e: CLI - verification failure for invalid root tsa cert

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

@junczhu junczhu closed this Aug 5, 2024
@junczhu junczhu reopened this Aug 5, 2024
@junczhu junczhu changed the title chore: bump-up tsa + e2e 1 chore: bump-up tsa + e2e Aug 5, 2024
@junczhu junczhu changed the title chore: bump-up tsa + e2e chore: bump-up tsa + e2e (CLI) Aug 5, 2024
@junczhu junczhu marked this pull request as ready for review August 6, 2024 02:54
@junczhu junczhu marked this pull request as draft August 23, 2024 11:18
@junczhu junczhu force-pushed the notation-go-v1.2.0-beta.1 branch from 870f20a to cbc8f34 Compare August 25, 2024 23:46
@junczhu junczhu marked this pull request as ready for review August 26, 2024 00:45
@junczhu
Copy link
Collaborator Author

junczhu commented Aug 26, 2024

Local test: junczhu#5

image

pkg/verifier/notation/notation.go Outdated Show resolved Hide resolved
test/bats/base-test.bats Outdated Show resolved Hide resolved
@junczhu junczhu changed the title feat: bump-up tsa + e2e (CLI) feat: bump-up tsa + e2e (CLI + K8S) Aug 27, 2024
@junczhu junczhu merged commit 7dabf47 into ratify-project:notation-go.1.2.0.beta_1 Aug 27, 2024
4 checks passed
junczhu added a commit that referenced this pull request Aug 28, 2024
junczhu added a commit that referenced this pull request Sep 2, 2024
junczhu added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants