Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratify helm chart should provide way to override notation trusted identities #1943

Open
1 task done
mannbiher opened this issue Nov 20, 2024 · 2 comments
Open
1 task done
Labels
enhancement New feature or request triage Needs investigation

Comments

@mannbiher
Copy link
Contributor

What would you like to be added?

Provide way to override notation trusted identities in helm chart. Currently it is set to *.
https://github.com/ratify-project/ratify/blob/dev/charts/ratify/templates/verifier.yaml#L40

          trustedIdentities:
            - "*"

Values could have notation.trustedIdentities property.

notation:
  enabled: true
  trustedIdentities:
  - arn:aws:signer:us-west-2:1234567890:/signing-profiles/my-account-signer

Anything else you would like to add?

The feature is required as we use AWS signer and want to verify signature created only by our account specific AWS signer. The current workaround is disable the helm chart notation verifier and create one outside helm chart with required trusted identities.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@mannbiher mannbiher added enhancement New feature or request triage Needs investigation labels Nov 20, 2024
@FeynmanZhou
Copy link
Collaborator

FeynmanZhou commented Nov 21, 2024

Hi @mannbiher , I assume you can override the * with your aws signer identity in trustedIdentities, without additional development. Is there anything fails?

@susanshi
Copy link
Collaborator

Hi @FeynmanZhou, It can be be done today ( by maintaining custom charts), but would be a better user experience if Ratify can expose this in the default chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Needs investigation
Projects
None yet
Development

No branches or pull requests

3 participants