Skip to content

Commit

Permalink
fix: missing status update in KMP controller (#1761)
Browse files Browse the repository at this point in the history
  • Loading branch information
duffney authored Sep 12, 2024
1 parent 630a2bd commit b32db85
Show file tree
Hide file tree
Showing 33 changed files with 1,538 additions and 1,312 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: ./.github/workflows/e2e-cli.yml
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

call_test_e2e_basic:
name: "run e2e on basic matrix"
if: ${{ ! (contains(github.event.pull_request.labels.*.name, 'safe to test') || github.event_name == 'workflow_dispatch') }}
Expand All @@ -26,7 +26,7 @@ jobs:
matrix:
KUBERNETES_VERSION: ["1.29.2"]
GATEKEEPER_VERSION: ["3.17.0"]
uses: ./.github/workflows/e2e-k8s.yml
uses: ./.github/workflows/e2e-k8s.yml
with:
k8s_version: ${{ matrix.KUBERNETES_VERSION }}
gatekeeper_version: ${{ matrix.GATEKEEPER_VERSION }}
Expand All @@ -39,10 +39,10 @@ jobs:
matrix:
KUBERNETES_VERSION: ["1.28.12", "1.29.2"]
GATEKEEPER_VERSION: ["3.15.0", "3.16.0", "3.17.0"]
uses: ./.github/workflows/e2e-k8s.yml
uses: ./.github/workflows/e2e-k8s.yml
with:
k8s_version: ${{ matrix.KUBERNETES_VERSION }}
gatekeeper_version: ${{ matrix.GATEKEEPER_VERSION }}
gatekeeper_version: ${{ matrix.GATEKEEPER_VERSION }}

build_test_aks_e2e_conditional:
name: "Build and run e2e Test on AKS with conditions"
Expand All @@ -60,9 +60,9 @@ jobs:
k8s_version: ${{ matrix.KUBERNETES_VERSION }}
gatekeeper_version: ${{ matrix.GATEKEEPER_VERSION }}
secrets: inherit

aks-test-cleanup:
needs: ['build_test_aks_e2e_conditional']
needs: ["build_test_aks_e2e_conditional"]
runs-on: ubuntu-latest
permissions:
id-token: write
Expand All @@ -79,7 +79,7 @@ jobs:
- name: Set up Go 1.22
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: "1.22"

- name: Az CLI login
uses: azure/login@6c251865b4e6290e7b78be643ea2d005bc51f69a # v2.1.1
Expand All @@ -90,4 +90,4 @@ jobs:

- name: clean up
run: |
make e2e-cleanup AZURE_SUBSCRIPTION_ID=${{ secrets.AZURE_SUBSCRIPTION_ID }}
make e2e-cleanup AZURE_SUBSCRIPTION_ID=${{ secrets.AZURE_SUBSCRIPTION_ID }}
6 changes: 3 additions & 3 deletions .github/workflows/cache-cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:
jobs:
cleanup:
runs-on: ubuntu-latest
steps:
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
with:
Expand All @@ -19,7 +19,7 @@ jobs:
- name: Cleanup
run: |
gh extension install actions/gh-actions-cache
echo "Fetching list of cache key"
cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH -L 100 | cut -f 1 )
Expand All @@ -34,4 +34,4 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
REPO: ${{ github.repository }}
BRANCH: refs/pull/${{ github.event.pull_request.number }}/merge
BRANCH: refs/pull/${{ github.event.pull_request.number }}/merge
16 changes: 8 additions & 8 deletions .github/workflows/clean-dev-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
cleanup-packages:
runs-on: ubuntu-latest
permissions:
packages: write
packages: write
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
Expand All @@ -19,15 +19,15 @@ jobs:

- name: Clean up ratify-crds-dev
uses: actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
with:
package-name: 'ratify-crds-dev'
package-type: 'container'
with:
package-name: "ratify-crds-dev"
package-type: "container"
min-versions-to-keep: 7
delete-only-pre-release-versions: "true"
- name: Clean up ratify-dev
uses: actions/delete-package-versions@e5bc658cc4c965c472efe991f8beea3981499c55 # v5.0.0
with:
package-name: 'ratify-dev'
package-type: 'container'
with:
package-name: "ratify-dev"
package-type: "container"
min-versions-to-keep: 7
delete-only-pre-release-versions: "true"
delete-only-pre-release-versions: "true"
7 changes: 3 additions & 4 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,18 @@

name: "CodeQL Scan"

on:
push:
branches:
branches:
- main
- dev
- 1.0.0*
pull_request:
branches:
branches:
- main
- dev
- 1.0.0*
schedule:
- cron: '30 1 * * 0'
- cron: "30 1 * * 0"
workflow_dispatch:

permissions: read-all
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/e2e-aks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ on:
workflow_call:
inputs:
k8s_version:
description: 'Kubernetes version'
description: "Kubernetes version"
required: true
default: '1.29.2'
default: "1.29.2"
type: string
gatekeeper_version:
description: 'Gatekeeper version'
description: "Gatekeeper version"
required: true
default: '3.17.0'
default: "3.17.0"
type: string

jobs:
Expand All @@ -37,7 +37,7 @@ jobs:
- name: Set up Go 1.22
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: "1.22"
- name: Az CLI login
uses: azure/login@6c251865b4e6290e7b78be643ea2d005bc51f69a # v2.1.1
with:
Expand Down Expand Up @@ -69,4 +69,4 @@ jobs:
with:
name: e2e-logs-aks-${{ inputs.k8s_version }}-${{ inputs.gatekeeper_version }}
path: |
logs-*.json
logs-*.json
15 changes: 7 additions & 8 deletions .github/workflows/e2e-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ jobs:
uses: apache/skywalking-eyes/dependency@cd7b195c51fd3d6ad52afceb760719ddc6b3ee91
with:
config: .github/licenserc.yml
flags:
--weak-compatible=true
flags: --weak-compatible=true
build:
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -89,8 +88,8 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}
markdown-link-check:
runs-on: ubuntu-latest
steps:
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
with:
Expand All @@ -103,7 +102,7 @@ jobs:
- name: Run link check
uses: gaurav-nelson/github-action-markdown-link-check@d53a906aa6b22b8979d33bc86170567e619495ec #3.10.3
with:
use-quiet-mode: 'no'
use-verbose-mode: 'yes'
config-file: '.github/workflows/markdown.links.config.json'
folder-path: 'docs/'
use-quiet-mode: "no"
use-verbose-mode: "yes"
config-file: ".github/workflows/markdown.links.config.json"
folder-path: "docs/"
12 changes: 6 additions & 6 deletions .github/workflows/e2e-k8s.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ on:
workflow_call:
inputs:
k8s_version:
description: 'Kubernetes version'
description: "Kubernetes version"
required: true
default: '1.29.2'
default: "1.29.2"
type: string
gatekeeper_version:
description: 'Gatekeeper version'
description: "Gatekeeper version"
required: true
default: '3.17.0'
default: "3.17.0"
type: string

jobs:
Expand All @@ -35,7 +35,7 @@ jobs:
- name: Set up Go 1.22
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: "1.22"

- name: Bootstrap e2e
run: |
Expand Down Expand Up @@ -70,4 +70,4 @@ jobs:
with:
name: e2e-logs-${{ inputs.k8s_version }}-${{ inputs.gatekeeper_version }}
path: |
logs-*.json
logs-*.json
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: "1.22"
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- name: golangci-lint
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/high-availability.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Set up Go 1.22
uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: "1.22"

- name: Bootstrap e2e
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-to-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pr_to_main

on:
schedule:
- cron: '30 8 * * 0' # early morning (08:30 UTC) every Sunday
- cron: "30 8 * * 0" # early morning (08:30 UTC) every Sunday
workflow_dispatch:

permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-charts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ jobs:
- name: Publish Helm charts
uses: stefanprodan/helm-gh-pages@0ad2bb377311d61ac04ad9eb6f252fb68e207260 # v1.7.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
10 changes: 5 additions & 5 deletions .github/workflows/publish-cosign-sample.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: publish-cosign-sample

on:
on:
workflow_dispatch:

env:
REGISTRY: ghcr.io

permissions:
contents: read

Expand All @@ -18,7 +18,7 @@ jobs:
contents: write
packages: write
id-token: write
steps:
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
with:
Expand All @@ -28,7 +28,7 @@ jobs:
uses: sigstore/cosign-installer@4959ce089c160fddf62f7b42464195ba1a56d382 # v3.6.0

- name: Get repo
run: |
run: |
echo "REPOSITORY=${{ env.REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
- name: Write signing key to disk
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-dev-assets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: publish-dev-assets

on:
schedule:
- cron: '30 8 * * 0' # early morning (08:30 UTC) every Sunday
- cron: "30 8 * * 0" # early morning (08:30 UTC) every Sunday
workflow_dispatch:

permissions: read-all
Expand Down Expand Up @@ -108,11 +108,11 @@ jobs:
run: |
sed -i '/^ repository:/c\ repository: ghcr.io/ratify-project/ratify-dev' charts/ratify/values.yaml
sed -i '/^ crdRepository:/c\ crdRepository: ghcr.io/ratify-project/ratify-crds-dev' charts/ratify/values.yaml
sed -i '/^ tag:/c\ tag: ${{ steps.prepare.outputs.version }}' charts/ratify/values.yaml
sed -i '/^ tag:/c\ tag: ${{ steps.prepare.outputs.version }}' charts/ratify/values.yaml
- name: helm package
run: |
helm package ./charts/ratify --version ${{ steps.prepare.outputs.semversion }}
helm package ./charts/ratify --version ${{ steps.prepare.outputs.semversionrolling }}
helm package ./charts/ratify --version ${{ steps.prepare.outputs.semversion }}
helm package ./charts/ratify --version ${{ steps.prepare.outputs.semversionrolling }}
- name: helm push
run: |
helm push ratify-${{ steps.prepare.outputs.semversion }}.tgz oci://${{ steps.prepare.outputs.chartrepo }}
Expand Down
18 changes: 8 additions & 10 deletions .github/workflows/publish-sample.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: publish-sample

on:
workflow_dispatch:
on:
workflow_dispatch:

env:
REGISTRY: ghcr.io

permissions:
contents: read

Expand All @@ -17,14 +17,14 @@ jobs:
permissions:
contents: write
packages: write
steps:
steps:
- name: Harden Runner
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
with:
egress-policy: audit

- name: Get repo
run: |
run: |
echo "REPOSITORY=${{ env.REGISTRY }}/${{ github.repository }}" >> $GITHUB_ENV
- name: Log in to the GHCR
Expand All @@ -35,9 +35,7 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}

- name: Copy signed sample test image
run:
oras cp -r wabbitnetworks.azurecr.io/ratify/notary-image:signed ${REPOSITORY}/notary-image:signed
run: oras cp -r wabbitnetworks.azurecr.io/ratify/notary-image:signed ${REPOSITORY}/notary-image:signed

- name: Copy unsigned sample test image
run:
oras cp wabbitnetworks.azurecr.io/ratify/notary-image:unsigned ${REPOSITORY}/notary-image:unsigned
- name: Copy unsigned sample test image
run: oras cp wabbitnetworks.azurecr.io/ratify/notary-image:unsigned ${REPOSITORY}/notary-image:unsigned
Loading

0 comments on commit b32db85

Please sign in to comment.