Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pagination to use new Styling Approach #1985

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 1, 2024

This PR uses the new Attribute Management approach for the Pagination blades.

Adjusting:

  • setPaginationWrapperAttributes
  • setPerPageFieldAttributes

Adding:

  • setPerPageWrapperAttributes (Customise the div element that wraps the per-page dropdown)
  • setCustomPaginationBlade (Allows the use of a custom pagination blade, rather than the package default)

Tests:

  • Refactor the PaginationVisuals Tests to split into themes
  • Utilise a base & feature based parent class
  • Begin to ensure that all themes have all tests (this is a larger piece of work)

Several tests still to write to ensure full coverage.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (0c8ec45) to head (220048d).
Report is 228 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1985      +/-   ##
=================================================
+ Coverage          87.30%   88.28%   +0.98%     
- Complexity          1672     1861     +189     
=================================================
  Files                150      176      +26     
  Lines               3891     4286     +395     
=================================================
+ Hits                3397     3784     +387     
- Misses               494      502       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Nov 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 23, 2024
@stale stale bot closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant