Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - Backports #1343

Closed
wants to merge 4 commits into from
Closed

V2 - Backports #1343

wants to merge 4 commits into from

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Sep 3, 2023

  • Update TK Language
  • Add setSearchPlaceholder() functionality
  • Add missing tests
  • Add CodeCov to V2

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

diat01 and others added 4 commits September 1, 2023 01:16
* Update tk.json

Fixed typos in Turkmen language

---------

Co-authored-by: diat01 <[email protected]>
* Add setSearchPlaceholder() functionality

---------

Co-authored-by: lrljoe <[email protected]>
* Add setSearchPlaceholder() functionality

* Fix styling

* Add CodeCov to V2

* Update PHPUnit Tests

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe added the In Progress I've started diagnosing a fix label Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2-master@26c596d). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff              @@
##             v2-master    #1343   +/-   ##
============================================
  Coverage             ?   91.16%           
  Complexity           ?      914           
============================================
  Files                ?       72           
  Lines                ?     2173           
  Branches             ?        0           
============================================
  Hits                 ?     1981           
  Misses               ?      192           
  Partials             ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stale
Copy link

stale bot commented Oct 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2023
@lrljoe
Copy link
Collaborator Author

lrljoe commented Oct 5, 2023

A few outstanding bugs will join this prior to merging and a v2 release.

@stale stale bot removed the wontfix This will not be worked on label Oct 5, 2023
Copy link

stale bot commented Nov 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 4, 2023
@stale stale bot closed this Nov 11, 2023
@lrljoe lrljoe reopened this Nov 13, 2023
@stale stale bot removed the wontfix This will not be worked on label Nov 13, 2023
Copy link

stale bot commented Dec 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 13, 2023
@stale stale bot closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress I've started diagnosing a fix wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants