Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] add tests on image characteristics #667

Open
jameslamb opened this issue May 1, 2024 · 2 comments
Open

[FEA] add tests on image characteristics #667

jameslamb opened this issue May 1, 2024 · 2 comments
Assignees
Labels
? - Needs Triage Need team to review and classify feature request New feature or request

Comments

@jameslamb
Copy link
Member

jameslamb commented May 1, 2024

Is your feature request related to a problem? Please describe.

Images published from this repo are intended for use in a wide variety of contexts. For example, they're used in several different cloud providers' bring-your-own container solutions (see https://docs.rapids.ai/deployment/stable/).

Those environments each have slightly different requirements for images you bring to them... things like default user, exposed ports, expected filepaths, etc.

When changes like #449 are made to modify the images here, there are currently not strong automatic protections against accidental regressions.

This issue proposes adding such protections, to improve release confidence and hopefully catch some types of issues during development instead of further downstream.

Describe the solution you'd like

I'm proposing the following:

  • on every commit to PRs or main here, test all built images with container-canary (https://github.com/NVIDIA/container-canary), with the following tests:
  • on every commit to PRs, test files in this repo with some static analyzers. For example:
    • hadolint for Dockerfiles (link)
    • shellcheck for shell scripts (link)
    • ruff for Python code (link)

Describe alternatives you've considered

N/A

Additional context

This proposal comes out of mine and @jacobtomlinson 's discussions around this: rapidsai/deployment#277

And would help with stuff like this:

I'd be happy to come do the work, just looking for a 👍🏻 / 👎🏻 on the general idea (cc @raydouglass @ajschmidt8 @AyodeAwe )

@jameslamb
Copy link
Member Author

jameslamb commented Jul 8, 2024

Based on my experiments in #670 so far, I think this will require some updates to container-canary:

I'd like to try contributing those, at some point.

@jameslamb
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant