You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Images published from this repo are intended for use in a wide variety of contexts. For example, they're used in several different cloud providers' bring-your-own container solutions (see https://docs.rapids.ai/deployment/stable/).
Those environments each have slightly different requirements for images you bring to them... things like default user, exposed ports, expected filepaths, etc.
When changes like #449 are made to modify the images here, there are currently not strong automatic protections against accidental regressions.
This issue proposes adding such protections, to improve release confidence and hopefully catch some types of issues during development instead of further downstream.
Is your feature request related to a problem? Please describe.
Images published from this repo are intended for use in a wide variety of contexts. For example, they're used in several different cloud providers' bring-your-own container solutions (see https://docs.rapids.ai/deployment/stable/).
Those environments each have slightly different requirements for images you bring to them... things like default user, exposed ports, expected filepaths, etc.
When changes like #449 are made to modify the images here, there are currently not strong automatic protections against accidental regressions.
This issue proposes adding such protections, to improve release confidence and hopefully catch some types of issues during development instead of further downstream.
Describe the solution you'd like
I'm proposing the following:
main
here, test all built images withcontainer-canary
(https://github.com/NVIDIA/container-canary), with the following tests:hadolint
for Dockerfiles (link)shellcheck
for shell scripts (link)ruff
for Python code (link)Describe alternatives you've considered
N/A
Additional context
This proposal comes out of mine and @jacobtomlinson 's discussions around this: rapidsai/deployment#277
And would help with stuff like this:
/var/run
#582I'd be happy to come do the work, just looking for a 👍🏻 / 👎🏻 on the general idea (cc @raydouglass @ajschmidt8 @AyodeAwe )
The text was updated successfully, but these errors were encountered: