-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDAARCHS should be NATIVE when building locally #254
Comments
I'd be in favor of this. There's no need to build all architectures by default IMO. |
Yes there is. When you change the list of archs, the sccache key changes. Since most devs have different GPUs than CI/other devs, the likelihood the build cache is populated for your flavor of compile flags/git commit/gpu versions etc. becomes less likely. This issue is about setting |
@etseidl you could also set the envvar to |
@trxcllnt Yes, I figured that out after I filed this. But it's still a little dicey since I'd have to remember to not commit that change 😄.
This is true for NVIDIA devs, but not for plebes like me. I was thinking that since there's already special handling for the sccache envvars, wherever that logic sits it could also modify |
That's true, there are certainly some tradeoffs there. It probably varies on a case-by-case basis whether or not your sccache hit rate is going to be good enough to be worth the extra compilation you do locally once you start changing things if you're only compiling for the native architecture. |
It's not just about your hit rate, you're also populating the cache for CI/other devs :-) |
100% agreed. If a user is using sccache, then they should be building for all archs by default. I agree with @etseidl that if you're not using sccache than using |
I wasn't thinking about the fact that sccache doesn't cache granularly enough to share artifacts between users who compile for all archs and those who compiles for a specific subset of them. Agreed, compiling for all archs makes sense if you have access to the shared cache. |
I'm doing a devcontainer build without GitHub auth. In ~coder/.bashrc
SCCACHE_BUCKET
andSCCACE_REGION
are unset, butCUDAARCHS
is left set as "RAPIDS" causing my build to target all architectures. I thinkCUDAARCHS
should either be unset or set to "NATIVE" in this case.The text was updated successfully, but these errors were encountered: