Testing 19621 #19692
Closed
Testing 19621 #19692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dledda-r7
added
the
payload-testing-branch
| path: metasploit-framework | ||
| ref: ${{ inputs.metasploit_framework_commit }} | ||
| ref: fix/met/java/symlinks |
There was a problem hiding this comment.
Looks like the Framework commit might be incorrect:
Suggested change
| ref: fix/met/java/symlinks | |
| ref: fix/met/java-win-symlink-tests |
There was a problem hiding this comment.
need more coffee :/
dledda-r7
force-pushed
the
testing-19621
branch
from
6338fd3 to
d41c57f
Compare
| @@ -185,9 +185,9 @@ jobs: | |||
| - name: Checkout metasploit-framework commit | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| repository: rapid7/metasploit-framework | |||
| repository: zeroSteiner/metasploit-framework | |||
There was a problem hiding this comment.
If we want to test the changes in this PR I believe we would need to point this at your forked repo and not Spencers, as you have branched off of Spencers branch. So we have his commits already, we are now additionally making changes on top of these:
Suggested change
| repository: zeroSteiner/metasploit-framework | |
| repository: dledda-r7/metasploit-framework |
| path: metasploit-framework | ||
| ref: ${{ inputs.metasploit_framework_commit }} | ||
| ref: fix/met/java-win-symlink-tests |
There was a problem hiding this comment.
and the same with your branch as well:
Suggested change
| ref: fix/met/java-win-symlink-tests | |
| ref: testing-19621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Can be ignored, only open to walk through testing payload changes as part of #19621