Makes some adjustments to the favorites command

[cgranleese-r7]

Closes #18219.

This PR implements some feedback gave on #18231.

It tidies up some code duplication and adds error handling for the scenario of a module is ever delete whilst in a users favorites file.

Verification

• Start msfconsole
• Favorite some modules - run favorite when using a module
• Then run favorites to see the list of favorites
• Use the index selection method to jump between modules - use 2
• Review code changes

[sjanusz-r7]

Works as expected 👍

msf6 payload(windows/x64/meterpreter_reverse_tcp) > favorites
[!] /Users/sjanusz/.msf4/fav_modules contains a module that can not be found - payloads/module/does/not/exist.

Favorites
=========

   #  Name                                         Disclosure Date  Rank    Check  Description
   -  ----                                         ---------------  ----    -----  -----------
   0  payload/windows/meterpreter/reverse_tcp                       normal  No     Windows Meterpreter (Reflective Injection), Reverse TCP Stager
   1  payload/windows/x64/meterpreter_reverse_tcp                   normal  No     Windows Meterpreter Shell, Reverse TCP Inline x64

Interact with a module by name or index. For example info 1, use 1 or use payload/windows/x64/meterpreter_reverse_tcp

msf6 payload(windows/x64/meterpreter_reverse_tcp) > use 0
msf6 payload(windows/meterpreter/reverse_tcp) > options

Module options (payload/windows/meterpreter/reverse_tcp):

...

View the full module info with the info, or info -d command.

msf6 payload(windows/meterpreter/reverse_tcp) > use 1
msf6 payload(windows/x64/meterpreter_reverse_tcp) > options

Module options (payload/windows/x64/meterpreter_reverse_tcp):

...

View the full module info with the info, or info -d command.

msf6 payload(windows/x64/meterpreter_reverse_tcp) > use 2
[-] Invalid module index: 2

[sjanusz-r7]

Release Notes

Adds ability to select favorite modules with the use command after running show favorites, similar to the search command.