-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve post/linux/gather/checkvm #18190
Conversation
Hey @jvoisin, I was able to test most of the changes in this PR and everything is looking good so far. I was wondering if you'd be able to test the Xen and Hyper-V detections for me? My dev machine is running Mac OSX so I can't run Hyper-V enabled Windows VMs in my VMware Fusion. I think I should be able to run Xen in a Linux VM in order to host another Linux VM to test the detection however the nested virtualization was giving me some issues. Let me know, thanks!
|
I don't think I'll be able to test Xen and Hyper-V anytime soon :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jvoisin, no worries on the Hyper-V / Xen testing, I'll see if anyone else on the team might be able to help out.
Testing this on a Hyper-V VM:
|
Xen's dom0 has `control_d` in its /proc/xen/capabilities
No need to run a binary if reading a file is enough
Based on @adfoster-r7's feedback.
Release NotesThis PR improves the linux checkvm post module by adding new techniques to identify the hypervisor in which the session is running. |
Sister of #18179 but for Linux.
Verification
List the steps needed to make sure this thing works