Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using API which is hinting at adding room properties, have a field on whether it should throw when editing existing IDs #69

Open
Miepee opened this issue Jun 22, 2024 · 0 comments

Comments

@Miepee
Copy link

Miepee commented Jun 22, 2024

Stuff like room.distanceFog will either add distanceFog objects or edit distanceFog objects depending on if the ID already exists or not.
However, from a user PoV, it is hard to know whether one accidentally used an id that already exists.
Thus, some field (that doesn't break backwards compatibility with older jsons) would be nice to have added where it then fails when you're editing a property when you meant to add a new one. Suggestion would be to name it throwOnEdit.

Same goes for relays, triggers, hudMemos, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant