Add support for pages in hints #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miepee
requested review from
duncathan and
henriquegemignani
and removed request for
duncathan
henriquegemignani
requested changes
May 23, 2024
| @@ -290,7 +290,10 @@ | |||
| "pattern": "[A-Z]+?_[0-9]+" | |||
| }, | |||
| "text": { | |||
| "type": "string" | |||
| "type": ["string", "array"], | |||
There was a problem hiding this comment.
Can you add a description to this field, so it's clear why it can be two types?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 87.63% 0.00% -87.64%
==========================================
Files 36 36
Lines 1990 1993 +3
==========================================
- Hits 1744 0 -1744
- Misses 246 1993 +1747 ☔ View full report in Codecov by Sentry. |
henriquegemignani
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #315