Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compare word hash in hash check #160

Open
Miepee opened this issue Jan 20, 2024 · 0 comments
Open

Don't compare word hash in hash check #160

Miepee opened this issue Jan 20, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Miepee
Copy link
Collaborator

Miepee commented Jan 20, 2024

but if the word hash changes and the actual hash doesn't, compatibility hasn't broken
which could happen from as benign a change as adding new hash words

The word hash however should still be shown to the end user if they have a hash mismatch.

@Miepee Miepee added the good first issue Good for newcomers label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant