kube-controller-manager pod fails to be created with kube-controller-manager-extra-mount flag

[skanakal]

Environmental Info:
RKE2 Version: v1.31.3+rke2r1

Node(s) CPU architecture, OS, and Version: x86_64, Ubuntu, 22.04

Cluster Configuration:

Describe the bug:

kube-controller-manager pod fails to be created with kube-controller-manager-extra-mount flag

Steps To Reproduce:

• Installed RKE2:

#/etc/rancher/rke2/config.yaml
      kube-controller-manager-extra-mount:
        - /tmp/example.txt:/tmp/example.txt
        - /var/lib/rancher/rke2/server/logs/:/var/lib/rancher/rke2/server/logs

Expected behavior:

  - hostPath:
      path: /tmp/example.txt
      type: File
    name: extra-mount-0
  - hostPath:
      path: /var/lib/rancher/rke2/server/logs/
      type: DirectoryOrCreate
    name: extra-mount-1

Actual behavior:

tail -f /var/lib/rancher/rke2/agent/pod-manifests/kube-controller-manager.yaml 
    name: file9
  - hostPath:
      path: /tmp/example.txt
      type: File
    name: extra-mount-0
  - hostPath:
      path: /var/lib/rancher/rke2/server/logs/
      type: File
    name: extra-mount-1

Additional context / logs:

https://jira.suse.com/browse/SURE-9493

[brandond]

How the mount is handled depends on whether or not something exists at that path, and if so, what kind of file it is. If you want to set the mount type manually, instead of having RKE2 try to guess it for you, use the four-parameter form, where the 3rd parameter is the mode (rw/ro) and the 4th is the mount type.

 kube-controller-manager-extra-mount:
- /var/lib/rancher/rke2/server/logs/:/var/lib/rancher/rke2/server/logs:rw:DirectoryOrCreate

• Ref: Properly handle files and sockets in extra mounts #5621

[brandond]

Edit: Ahh, I see that there is incorrect behavior if there are multiple entries that should be of different types, but the type is left auto-detected instead of manually specified.

As a workaround, I'd suggest manually specifying the type in all the entries, as shown above.