Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updatecli: use semver versionfilter #6402

Open
14 tasks done
mgfritch opened this issue Jul 24, 2024 · 1 comment
Open
14 tasks done

updatecli: use semver versionfilter #6402

mgfritch opened this issue Jul 24, 2024 · 1 comment
Assignees
@mgfritch
Labels
kind/updatecli
Milestone
2024-12 Release C...

Comments

@mgfritch
Copy link
Contributor

mgfritch commented Jul 24, 2024 •
edited
Loading

Follow up on the suggestions made by @olblak: #6371 (comment)

UpdateCli version bump PRs should use the semver instead of the latest tag:

  • remove typefilter latest: true
  • versionfilter type should be semver instead of latest

For example:

     typefilter:
       release: true
       draft: false
       prerelease: false
     versionfilter:
       kind: semver

TODO:
@mgfritch mgfritch added this to the August 2024 Release Cycle milestone Jul 24, 2024
@mgfritch mgfritch self-assigned this Jul 24, 2024
mgfritch added a commit to mgfritch/image-build-sriov-cni that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
8573e88 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-ib-sriov-cni that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
da306ca 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-sriov-operator that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
573f5ea 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-sriov-network-device-plugin that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
3ca54b8 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-sriov-network-resources-injector that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
b973f01 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-node-feature-discovery that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
e5fee88 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to mgfritch/image-build-whereabouts that referenced this issue Jul 31, 2024
@mgfritch
updatecli: use semver versionfilter
0a1e4d0 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
This was referenced Jul 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
mgfritch added a commit to mgfritch/image-build-dns-nodecache that referenced this issue Aug 1, 2024
@mgfritch
updatecli: use semver versionfilter
37cab37 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 1, 2024
Merged
mgfritch added a commit to mgfritch/image-build-cni-plugins that referenced this issue Aug 1, 2024
@mgfritch
updatecli: use semver versionfilter
fde1233 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 1, 2024
Open
mgfritch added a commit to rancher/image-build-multus that referenced this issue Aug 1, 2024
@mgfritch
updatecli: use semver versionfilter
bd239a6 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 1, 2024
Merged
mgfritch added a commit to rancher/image-build-flannel that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
f40f378 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to rancher/image-build-flannel that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
0c83a7a 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 2, 2024
Open
mgfritch added a commit to rancher/image-build-coredns that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
02f3ebe 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
mgfritch added a commit to rancher/image-build-coredns that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
116f5c2 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 2, 2024
Merged
mgfritch added a commit to mgfritch/image-build-calico that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
aadd6d0 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 2, 2024
Open
mgfritch added a commit to mgfritch/rke2-charts that referenced this issue Aug 2, 2024
@mgfritch
updatecli: use semver versionfilter
3de2c16 
Version bump PRs should use the semver instead of the latest tag

Issue: rancher/rke2#6402
Signed-off-by: Michael Fritch <[email protected]>
@mgfritch mgfritch mentioned this issue Aug 2, 2024
Open
@caroline-suse-rancher
Copy link
Contributor

Hey @mgfritch is this considered done? I see a couple of unmerged PRs, so maybe not. Let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgfritch mgfritch

Labels
kind/updatecli
Projects
None yet
Milestone
2024-12 Release Cycle
Development

No branches or pull requests
3 participants
@mgfritch @mdrahman-suse @caroline-suse-rancher