Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require name input for policies and policy server #952

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jordojordo
Copy link
Member

Fix #898

This will require the name fields to be filled out when creating either a policy server or policy.

@jordojordo jordojordo added the kind/bug Something isn't working label Nov 7, 2024
@jordojordo jordojordo added this to the 2.1.0 milestone Nov 7, 2024
@jordojordo jordojordo self-assigned this Nov 7, 2024
@jordojordo jordojordo modified the milestones: 2.1.0, 3.0.0 Nov 7, 2024
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Remove commented out save method
@jordojordo jordojordo merged commit 121b4c4 into rancher:main Nov 8, 2024
1 check failed
@jordojordo jordojordo deleted the policy-name branch November 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy can be created without name
3 participants