Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vue3] Enabled tracing &metrics are not detected #939

Open
kravciak opened this issue Oct 30, 2024 · 3 comments · Fixed by #917
Open

[vue3] Enabled tracing &metrics are not detected #939

kravciak opened this issue Oct 30, 2024 · 3 comments · Fixed by #917
Assignees
@jordojordo
Labels
area/vue3 kind/bug Something isn't working status/backport-candidate
Milestone
3.0.0

Comments

@kravciak
Copy link
Collaborator

kravciak commented Oct 30, 2024 •
edited
Loading

Same issue for tracing & metrics:

Screencast.From.2024-10-30.18-23-58.mp4
@kravciak kravciak added the kind/bug Something isn't working label Oct 30, 2024
@kravciak kravciak changed the title [vue3] Enabled tracing is not detected [vue3] Enabled tracing &metrics are not detected Oct 30, 2024
@jordojordo jordojordo self-assigned this Nov 1, 2024
@jordojordo jordojordo added this to the 3.0.0 milestone Nov 1, 2024
@jordojordo
Copy link
Member

Looks like the catalog.cattle.io.app endpoint no longer returns the values used when installing the application, we are searching for app.spec.values.telemetry.{property} to determine if telemetry for tracing and metrics is enabled.

api

We could instead look at the ConfigMap for the kubewarden-collector installed by the kubewarden controller chart to determine if tracing or metrics is enabled.

collector

@jordojordo jordojordo mentioned this issue Nov 1, 2024
Merged
@jordojordo jordojordo moved this to Pending review in Kubewarden Nov 1, 2024
@kravciak
Copy link
Collaborator Author

kravciak commented Nov 5, 2024

Fixed in #917, closing

@kravciak kravciak closed this as completed Nov 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kubewarden Nov 5, 2024
@kravciak
Copy link
Collaborator Author

kravciak commented Nov 7, 2024

I am reopening this because bug is also in rancher 2.8.10-alpha1 & v2.9.4-alpha2, we need to backport the fix.

@kravciak kravciak reopened this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordojordo jordojordo

Labels
area/vue3 kind/bug Something isn't working status/backport-candidate
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Refactor for Vue3 compliance jordojordo/ui
2 participants
@kravciak @jordojordo