Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 Migration tool adds incorrect annotation, blocking app from loading #12655

Open
richard-cox opened this issue Nov 21, 2024 · 0 comments
Open
Labels
area/extensions kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: 2.10.0

Describe the bug

  • Using the migration tool will update the extensions package.json annotations
  • However it uses the wrong value, which means the dashboard will ignore it and assume the extension is not compatible with vue3 world
    • Adds catalog.cattle.io/ui-extension-version
    • Should add catalog.cattle.io/ui-extensions-version
    • See creators/extension/migrate/tasks/packageUpdates.js

To Reproduce

Result

  • pkg//package.json contains incorrect annotation catalog.cattle.io/ui-extension-version

Expected Result

  • pkg//package.json contains incorrect annotation catalog.cattle.io/ui-extensions-version
@richard-cox richard-cox added this to the v2.10.1 milestone Nov 21, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extensions kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

1 participant