Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with extensions creator's package in branches #12635

Closed
aalves08 opened this issue Nov 21, 2024 · 1 comment · Fixed by #12638
Closed

Fix some issues with extensions creator's package in branches #12635

aalves08 opened this issue Nov 21, 2024 · 1 comment · Fixed by #12638

Comments

@aalves08
Copy link
Member

aalves08 commented Nov 21, 2024

Fix some issues with extensions creator's package in branches:

release-2.8
https://github.com/rancher/dashboard/blob/release-2.8/creators/extension/app/files/.github/workflows/build-extension-charts.yml

  • missing input tagged_release: ${{ github.ref_name }} for job
  • remove push and pull triggers and replace with release: types: [released] (keep workflow_dispatch)
  • uses should target release-2.8 branch

release-2.9
https://github.com/rancher/dashboard/blob/release-2.9/creators/extension/app/files/.github/workflows/build-extension-charts.yml

  • missing input tagged_release: ${{ github.ref_name }} for job
  • uses should target release-2.9 branch

master - https://github.com/rancher/dashboard/blob/master/creators/extension/app/files/.github/workflows/build-extension-charts.yml

  • missing input tagged_release: ${{ github.ref_name }} for job

https://github.com/rancher/dashboard/blob/master/creators/extension/app/app.package.json

  • update dependencies and resolutions so that the output is:
"dependencies": {
    "@rancher/shell": "^3.0.0"
  },
  "resolutions": {
    "@types/node": "~20.10.0",
    "@types/lodash": "4.17.5"
  },

After this, create releases for all creators package versions

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 21, 2024
@aalves08 aalves08 added kind/bug and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 21, 2024
@aalves08 aalves08 self-assigned this Nov 21, 2024
@richard-cox
Copy link
Member

Here's a few other strange related to creators things i picked up (WIP)

  • when using the ext creator it provided the wrong catalog.cattle.io/rancher-version (in 2.10 it was setting 2.9.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants