Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize lang param with page template #451

Open
yileifeng opened this issue Jul 16, 2024 · 0 comments
Open

Normalize lang param with page template #451

yileifeng opened this issue Jul 16, 2024 · 0 comments
Labels
Canada.ca Template Work in and around the Canada.ca/CDTS template Priority: Low This task can is low priority and can wait if high priority tasks exist

Comments

@yileifeng
Copy link
Member

Description

Found during code adventures demo, can explore the idea of keeping URL lang param consistent with the source page language. For example, changing the URL param from 'en' to 'fr' loads the FR storylines config in an English Canada.ca template. Whereas changing the source page lang to French will reload the page and the FR config properly.

Proposed solution

When changing the router lang parameter, reload the entire app with the correct language Canada.ca template. If there is no template used, keep the current behavior.
@yileifeng yileifeng added the Canada.ca Template Work in and around the Canada.ca/CDTS template label Jul 16, 2024
@szczz szczz added the Priority: Low This task can is low priority and can wait if high priority tasks exist label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Canada.ca Template Work in and around the Canada.ca/CDTS template Priority: Low This task can is low priority and can wait if high priority tasks exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szczz @yileifeng