Skip to content

Commit

Permalink
Merge pull request #472 from cpsievert/rm-overflow-hidden
Browse files Browse the repository at this point in the history
  • Loading branch information
cpsievert authored Nov 6, 2023
2 parents 7c5594a + 91968f7 commit 943a819
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ URL: https://github.com/ramnathv/htmlwidgets
BugReports: https://github.com/ramnathv/htmlwidgets/issues
Imports:
grDevices,
htmltools (>= 0.5.4),
htmltools (>= 0.5.7),
jsonlite (>= 0.9.16),
knitr (>= 1.8),
rmarkdown,
Expand Down
16 changes: 2 additions & 14 deletions R/htmlwidgets.R
Original file line number Diff line number Diff line change
Expand Up @@ -183,14 +183,7 @@ toHTML <- function(x, standalone = FALSE, knitrOptions = NULL) {
width = validateCssUnit(sizeInfo$width),
height = validateCssUnit(sizeInfo$height),
),
class = paste(
name, "html-widget",
# bindFillRole() puts `overflow:auto` to items by default,
# which is a sensible generic default, but in the context of
# widgets, we can pretty easily run into non-pixel-perfect situations
# (e.g., the widget JS uses something like offsetHeight to resize itself)
if (sizeInfo$fill) "html-fill-item-overflow-hidden"
),
class = paste(name, "html-widget"),
width = sizeInfo$width,
height = sizeInfo$height
)
Expand Down Expand Up @@ -488,12 +481,7 @@ shinyWidgetOutput <- function(outputId, name, width, height, package = name,
class = paste0(
name, " html-widget html-widget-output",
if (reportSize) " shiny-report-size",
if (reportTheme) " shiny-report-theme",
# bindFillRole() puts `overflow:auto` to items by default,
# which is a sensible generic default, but in the context of
# widgets, we can pretty easily run into non-pixel-perfect situations
# (e.g., the widget JS uses something like offsetHeight to resize itself)
if (fill) " html-fill-item-overflow-hidden"
if (reportTheme) " shiny-report-theme"
),
style = css(
width = validateCssUnit(width),
Expand Down

0 comments on commit 943a819

Please sign in to comment.