Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hey approve prometheus #271

Open
zgxme opened this issue Feb 12, 2022 · 4 comments
Open

hey approve prometheus #271

zgxme opened this issue Feb 12, 2022 · 4 comments

Comments

@zgxme
Copy link

zgxme commented Feb 12, 2022

Hey, I have an idea of making hey realize visualization. And I made it,let hey approve prometheus.
Does the community have any plans for this?

this is my final version
https://github.com/rickzhen/hey/releases/tag/v0.2.0

@FrenchBen
Copy link

I think it would be more useful to have a prometheus output supported, instead of the custom integration that you created.
hey already supports an output type of CSV.

-o  Output type. If none provided, a summary is printed.
      "csv" is the only supported alternative. Dumps the response
      metrics in comma-separated values format.

Adding support for something like json, would allow a quick and easy integration via https://github.com/prometheus-community/json_exporter

@zgxme
Copy link
Author

zgxme commented Mar 25, 2022

@FrenchBen yeah, good idea. I want to support real-time metrics.

@FrenchBen
Copy link

You mean for the metrics to show up before the run is actually completed? With hey being a tool that has a start/end, it doesn't seem to align with a real-time metrics idea.
I see the above as something useful, where hey could run as a cronjob, and for the results to be collected in Prometheus

@zgxme
Copy link
Author

zgxme commented Mar 26, 2022

@FrenchBen ok, I got it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants