Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Barbarian Nationality ID should be 0 and not -1 #75

Open
rajko-horvat opened this issue Sep 30, 2024 · 0 comments
Open

The Barbarian Nationality ID should be 0 and not -1 #75

rajko-horvat opened this issue Sep 30, 2024 · 0 comments
Assignees

Comments

@rajko-horvat
Copy link
Owner

rajko-horvat commented Sep 30, 2024

Describe the bug
The old Sve/Map save format stores Barbarian Nationality ID as -1, but in Nations array the proper Barbarian Nationality ID is 0.

To Reproduce
Steps to reproduce the behavior:

  1. When Barbarian unit conquers the city an Array Out Of Bounds error happens.

Expected behavior
The Barbarian nationality should clearly be displayed when a city is conquered by Barbarians.

OS version(s) affected:

  • All
@rajko-horvat rajko-horvat self-assigned this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant