Handling erroneous case with issue #11

rajbos · Nov 26, 2021 · 094353b · 094353b
1 parent b693c07
commit 094353b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/src/get-codeql-results.js b/src/get-codeql-results.js
@@ -2,10 +2,15 @@ module.exports = async ({github, owner, repo}) => {
 
     console.log(`Found owner [${owner}] and repo [${repo}] to check the code scanning alerts for`)
 
-    const recentScansData = await github.rest.codeScanning.listRecentAnalyses({
-        owner,
-        repo,
-    })
+    let recentScansData
+    try {        
+        recentScansData = await github.rest.codeScanning.listRecentAnalyses({
+            owner,
+            repo,
+        })    
+    } catch (error) {
+        console.log(`Error getting recent scans: [${error}]`)
+    }
 
     let scanResult = {
         created_at: null,
@@ -14,6 +19,7 @@ module.exports = async ({github, owner, repo}) => {
         error: null,
         environment: null
     }
+
     if (recentScansData === undefined) {
         console.log(`recentScansData is undefined`)
     }

diff --git a/src/start-and-wait-codeql.js b/src/start-and-wait-codeql.js
@@ -88,9 +88,17 @@ module.exports = async ({github, owner, repo, path, ref}) => {
             })
 
             // check each job
+            let successfullJobs = 0
             console.log(`Job results:`)
             for (const job of data.jobs) {
                 console.log(` - Job [${job.name}] status [${job.status}] conclusion [${job.conclusion}]`)
+                if (job.status === 'completed' && job.conclusion === 'success') {
+                    successfullJobs++
+                }
+            }
+
+            if (successfullJobs === 0) {
+                // post this information back into the request issue
             }
 
             return 1