Make compilers option required to avoid nil testing just for testing

lib/propshaft/load_path.rb

@@ -3,7 +3,7 @@
 class Propshaft::LoadPath
   attr_reader :paths, :compilers, :version
 
-  def initialize(paths = [], compilers: nil, version: nil)
+  def initialize(paths = [], compilers:, version: nil)
     @paths, @compilers, @version = dedup(paths), compilers, version
   end
 
@@ -12,7 +12,7 @@ def find(asset_name)
   end
 
   def find_references_by(asset)
-    compilers&.referenced_by(asset) || Set.new
+    compilers.referenced_by(asset) || Set.new
   end
 
   def assets(content_types: nil)

test/propshaft/compilers_test.rb

@@ -20,6 +20,7 @@ class Propshaft::CompilersTest < ActiveSupport::TestCase
   private
     def find_asset(logical_path)
       root_path = Pathname.new("#{__dir__}/../fixtures/assets/first_path")
-      Propshaft::Asset.new(root_path.join(logical_path), logical_path: logical_path, load_path: Propshaft::LoadPath.new([ root_path ]))
+      load_path = Propshaft::LoadPath.new([ root_path ], compilers: Propshaft::Compilers.new(nil))
+      Propshaft::Asset.new(root_path.join(logical_path), logical_path: logical_path, load_path: load_path)
     end
 end

test/propshaft/load_path_test.rb

@@ -6,7 +6,7 @@ class Propshaft::LoadPathTest < ActiveSupport::TestCase
     @load_path = Propshaft::LoadPath.new [
       Pathname.new("#{__dir__}/../fixtures/assets/first_path"),
       Pathname.new("#{__dir__}/../fixtures/assets/second_path").to_s
-    ]
+    ], compilers: Propshaft::Compilers.new(nil)
   end
 
   test "find asset that only appears once in the paths" do
@@ -44,15 +44,15 @@ class Propshaft::LoadPathTest < ActiveSupport::TestCase
   end
 
   test "manifest with version" do
-    @load_path = Propshaft::LoadPath.new(@load_path.paths, version: "1")
+    @load_path = Propshaft::LoadPath.new(@load_path.paths, version: "1", compilers: Propshaft::Compilers.new(nil))
     @load_path.manifest.tap do |manifest|
       assert_equal "one-c9373b68.txt", manifest["one.txt"]
       assert_equal "nested/three-a41a5d38.txt", manifest["nested/three.txt"]
     end
   end
 
   test "missing load path directory" do
-    assert_nil Propshaft::LoadPath.new(Pathname.new("#{__dir__}/../fixtures/assets/nowhere")).find("missing")
+    assert_nil Propshaft::LoadPath.new(Pathname.new("#{__dir__}/../fixtures/assets/nowhere"), compilers: Propshaft::Compilers.new(nil)).find("missing")
   end
 
   test "deduplicate paths" do
@@ -62,7 +62,7 @@ class Propshaft::LoadPathTest < ActiveSupport::TestCase
       "app/assets/stylesheets",
       "app/assets/images",
       "app/assets"
-    ]
+    ], compilers: Propshaft::Compilers.new(nil)
 
     paths = load_path.paths
     assert_equal 2, paths.count
@@ -73,6 +73,7 @@ class Propshaft::LoadPathTest < ActiveSupport::TestCase
   private
     def find_asset(logical_path)
       root_path = Pathname.new("#{__dir__}/../fixtures/assets/first_path")
-      Propshaft::Asset.new(root_path.join(logical_path), logical_path: logical_path, load_path: Propshaft::LoadPath.new([ root_path ]))
+      load_path = Propshaft::LoadPath.new([ root_path ], compilers: Propshaft::Compilers.new(nil))
+      Propshaft::Asset.new(root_path.join(logical_path), logical_path: logical_path, load_path: load_path)
     end
 end

test/propshaft/output_path_test.rb

@@ -64,7 +64,8 @@ class Propshaft::OutputPathTest < ActiveSupport::TestCase
 
   private
     def output_asset(filename, content, created_at: Time.now)
-      asset = Propshaft::Asset.new(nil, logical_path: filename, load_path: Propshaft::LoadPath.new)
+      load_path = Propshaft::LoadPath.new([], compilers: Propshaft::Compilers.new(nil))
+      asset = Propshaft::Asset.new(nil, logical_path: filename, load_path: load_path)
       asset.stub :content, content do
         output_path = @output_path.path.join(asset.digested_path)
         `touch -mt #{created_at.strftime('%y%m%d%H%M')} #{output_path}`

test/propshaft/resolver/dynamic_test.rb

@@ -3,7 +3,7 @@
 
 class Propshaft::Resolver::DynamicTest < ActiveSupport::TestCase
   setup do
-    @load_path = Propshaft::LoadPath.new Pathname.new("#{__dir__}/../../fixtures/assets/first_path")
+    @load_path = Propshaft::LoadPath.new Pathname.new("#{__dir__}/../../fixtures/assets/first_path"), compilers: Propshaft::Compilers.new(nil)
     @resolver  = Propshaft::Resolver::Dynamic.new(load_path: @load_path, prefix: "/assets")
   end
 

test/test_helper.rb

@@ -14,6 +14,8 @@ class ActiveSupport::TestCase
     def find_asset(logical_path, fixture_path:)
       root_path = Pathname.new("#{__dir__}/fixtures/assets/#{fixture_path}")
       path = root_path.join(logical_path)
-      Propshaft::Asset.new(path, logical_path: logical_path, load_path: Propshaft::LoadPath.new([ root_path ]))
+      load_path = Propshaft::LoadPath.new([ root_path ], compilers: Propshaft::Compilers.new(nil))
+
+      Propshaft::Asset.new(path, logical_path: logical_path, load_path: load_path)
     end
 end