Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case had a bug and correctly started to fail after the rails/rails#43735.
So before that Rails' PR:
@cache_this
instance variable variable was not reset after the firstget
in that test caseget
, the action was not executed andcontent_to_cache
returned a stale@cache_this
and compared it to the cached response from the actionAfter the Rails' PR:
@cache_this
is reset tonil
before the secondget
content_to_cache
returnnil
from the step 1, but cached response is not equal tonil
, so here is the test failureHaving
cached_time = content_to_cache
line is incorrect and this bug was unnoticed before that PR, so we need to remove it.