Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOM nesting issues and update class to className in Project component #14

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jhonboyy
Copy link
Contributor

Summary:

This pull request addresses two main issues identified in the Project.jsx component:

1.	DOM Nesting Warning:
•	A <div> was incorrectly nested inside a <p> element, which caused React to issue a DOM nesting validation warning. This PR replaces the <p> tag with a <div> or <span> where necessary to resolve this issue.
2.	class vs className:
•	The usage of class in JSX was generating a warning since React expects className for assigning CSS classes. All instances of class have been updated to className as per React standards.

Changes made:

•	Refactored the DOM structure in Project.jsx to ensure proper element nesting (replaced <p> tags with appropriate containers).
•	Replaced all occurrences of class with className in JSX to prevent React warnings.
•	Ensured that the <FaLocationArrow /> icon is positioned correctly outside of the clickable text container.

Testing:

•	Verified that the DOM structure is now valid and no warnings appear in the console.
•	Confirmed that navigation and layout functionality remain intact after the changes.

Let me know if any additional changes or adjustments are required!

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 11:57am

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for rahulvijay ready!

Name Link
🔨 Latest commit 0455397
🔍 Latest deploy log https://app.netlify.com/sites/rahulvijay/deploys/66e96e9ea731c10008af1b23
😎 Deploy Preview https://deploy-preview-14--rahulvijay.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78
Accessibility: 81
Best Practices: 92
SEO: 69
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jhonboyy
Copy link
Contributor Author

Hey, just wondering if you could review this :)

@rahulvijay81
Copy link
Owner

rahulvijay81 commented Sep 19, 2024

@jhonboyy Thanks for changes

I’m looking for a new background color for my site. Do you have any suggestions?

#16

@rahulvijay81 rahulvijay81 merged commit 85ac997 into rahulvijay81:main Sep 19, 2024
6 checks passed
@jhonboyy
Copy link
Contributor Author

@jhonboyy Thanks for changes

I’m looking for a new background color for my site. Do you have any suggestions?

#16
Actually no, I think it's fine like this.

@rahulvijay81
Copy link
Owner

@jhonboyy Thanks for changes
I’m looking for a new background color for my site. Do you have any suggestions?
#16
Actually no, I think it's fine like this.

Experimenting with different colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants