Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic field name to cat4 error messages #2996

Closed
5 of 8 tasks
jtimpe opened this issue May 17, 2024 · 3 comments · Fixed by #3051
Closed
5 of 8 tasks

Add dynamic field name to cat4 error messages #2996

jtimpe opened this issue May 17, 2024 · 3 comments · Fixed by #3051
Assignees
Labels
dev QASP Review Refined Ticket has been refined at the backlog refinement

Comments

@jtimpe
Copy link

jtimpe commented May 17, 2024

Description:
Per Alex's comment on #2879, cat4 error messages should include the field name. The value has been hard-coded in as part of #2879's changes, but the string should dynamically insert the relevant field name (and/or the field's friendly name, if applicable) from the schema instead.

Acceptance Criteria:

  • Cat4 error messages include the field name and/or friendly_name, dynamically pulled from the schema stored alongside each record
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:

Open Questions:
N/A

@jtimpe jtimpe added the dev label May 17, 2024
@jtimpe jtimpe mentioned this issue May 17, 2024
28 tasks
@robgendron robgendron added the Refined Ticket has been refined at the backlog refinement label May 21, 2024
@robgendron robgendron changed the title Add dynamic field name and/or friendly name to cat4 error messages Add dynamic field name to cat4 error messages May 21, 2024
@elipe17 elipe17 self-assigned this Jun 27, 2024
@elipe17 elipe17 added the raft review This issue is ready for raft review label Jun 27, 2024
@robgendron
Copy link

Update: Pending 1 more review

@robgendron
Copy link

Testing changes from reviews, re-request coming soon.

@reitermb
Copy link

Jan available to field questions while Eric is OOO

@robgendron robgendron added QASP Review and removed raft review This issue is ready for raft review labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev QASP Review Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants