Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As tech lead, i need sections 3 and 4 files rejected if the T6, T7, M6, or M7 records cannot be parsed. #2754

Closed
10 tasks
ADPennington opened this issue Nov 22, 2023 · 1 comment · Fixed by #2867
Assignees
Labels
dev Refined Ticket has been refined at the backlog refinement

Comments

@ADPennington
Copy link
Collaborator

ADPennington commented Nov 22, 2023

Description:

In #2731 I noticed that the M7 record that did not have the correct length was not parsed but the status was "partially accepted with errors". see here.

Eric explained:

In the event that the file had more than one record, those records could be correct/have no preparse errors and would parse correctly/be added to the DB. That is why the status is partially accepted.

This makes more sense for the other sections that have multiple record types (excluding header, trailer records), but all of the parse-able data needed for sections 3 and 4 are all in the T6/T7 or M6/M7 record. So if one of these records cant be parsed and added to db, the status should be rejected.

This should expand to section 1 and 2 files as well - if no records are successfully processed, the summary status should be Rejected.

  • look at DataFileSummary.get_status to add in a row count check

Acceptance Criteria:
Create a list of functional outcomes that must be achieved to complete this issue

  • If the T7 record cannot be parsed, the status of the file is rejected.
  • If the M7 record cannot be parsed, the status of the file is rejected.
  • If the M6 record cannot be parsed, the status of the file is rejected.
  • If the T6 record cannot be parsed, the status of the file is rejected.
  • Testing Checklist has been run and all tests pass
  • README is updated, if necessary

Tasks:
Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

  • Task 1
  • Task 2
  • Task 3
  • Run Testing Checklist and confirm all tests pass

Notes:
Add additional useful information, such as related issues and functionality that isn't covered by this specific issue, and other considerations that will be helpful for anyone reading this

  • Relevant to Sections 3 and 4 TANF, SSP, Tribal TANF files.
  • may also be relevant to Sections 1 and 4 files that are not "complete" see comment here
  • Note 3

Supporting Documentation:
Please include any relevant log snippets/files/screen shots

  • Doc 1
  • Doc 2

Open Questions:
Please include any questions or decisions that must be made before beginning work or to confidently call this issue complete

  • Open Question 1
  • Open Question 2
@ADPennington ADPennington changed the title [WIP] as tech lead, i need sections 3 and 4 files rejected if the T7 or M7 records cannot be processed. [WIP] as tech lead, i need sections 3 and 4 files rejected if the T7 or M7 records cannot be parsed. Nov 22, 2023
@jtimpe jtimpe changed the title [WIP] as tech lead, i need sections 3 and 4 files rejected if the T7 or M7 records cannot be parsed. As tech lead, i need sections 3 and 4 files rejected if the T7 or M7 records cannot be parsed. Nov 28, 2023
@jtimpe jtimpe added the Refined Ticket has been refined at the backlog refinement label Nov 28, 2023
@ADPennington ADPennington changed the title As tech lead, i need sections 3 and 4 files rejected if the T7 or M7 records cannot be parsed. As tech lead, i need sections 3 and 4 files rejected if the T6, T7, M6, or M7 records cannot be parsed. Jan 11, 2024
@ADPennington
Copy link
Collaborator Author

note for dev team: this issue was also detected in Section 1 and 2 when testing in #2834 with a file that had only 1 non-header/trailer record. OFA does not expect one record in section 1 and 2 files, and we think this would be caught once #2818 is implemented (because it would be evidence that the STT is submitting partial data). cc: @andrew-jameson @elipe17 @jtimpe @raftmsohani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Refined Ticket has been refined at the backlog refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants