From 238e85e6cf778e845b56641a62c059ea50236d3e Mon Sep 17 00:00:00 2001 From: Andrew <84722778+andrew-jameson@users.noreply.github.com> Date: Fri, 2 Jun 2023 13:43:27 -0400 Subject: [PATCH] Adding "beta" banners to relevant error report sections (#2522) * Update views.py * Update views.py * Update SubmissionHistory.jsx * Update SubmissionHistory.test.js * Apply suggestions from code review Co-authored-by: Miles Reiter * lint fixes --------- Co-authored-by: Miles Reiter Co-authored-by: Alex P <63075587+ADPennington@users.noreply.github.com> Co-authored-by: andrew-jameson --- tdrs-backend/tdpservice/parsers/views.py | 6 ++++++ .../src/components/SubmissionHistory/SubmissionHistory.jsx | 2 +- .../components/SubmissionHistory/SubmissionHistory.test.js | 5 ++++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tdrs-backend/tdpservice/parsers/views.py b/tdrs-backend/tdpservice/parsers/views.py index 90023597b..d39965ee3 100644 --- a/tdrs-backend/tdpservice/parsers/views.py +++ b/tdrs-backend/tdpservice/parsers/views.py @@ -52,6 +52,12 @@ def _get_xls_serialized_file(self, data): 'row_number', 'column_number'] + # write beta banner + worksheet.write(row, col, + "Error reporting in TDP is still in development." + + "We'll be in touch when it's ready to use!" + + "For now please refer to the reports you receive via email") + row, col = 2, 0 # write csv header [worksheet.write(row, col, key) for col, key in enumerate(report_columns)] diff --git a/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx b/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx index 071b19b60..49117a8e9 100644 --- a/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx +++ b/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx @@ -78,7 +78,7 @@ const SectionSubmissionHistory = ({ section, label, files }) => { Submitted On Submitted By File Name - Error Reports + Error Reports (In development) diff --git a/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js b/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js index 23d538df3..72f3e65f8 100644 --- a/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js +++ b/tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.test.js @@ -241,7 +241,10 @@ describe('SubmissionHistory', () => { expect(screen.queryByText('test5.txt')).not.toBeInTheDocument() expect(screen.queryByText('test6.txt')).toBeInTheDocument() - expect(screen.queryByText('Error Reports')).toBeInTheDocument() + expect( + screen.queryByText('Error Reports (In development)') + ).toBeInTheDocument() + expect(screen.queryByText('Currently Unavailable')).toBeInTheDocument() })