Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove knowledge of tests from code #112

Open
rafecolton opened this issue Aug 13, 2014 · 0 comments
Open

Remove knowledge of tests from code #112

rafecolton opened this issue Aug 13, 2014 · 0 comments

Comments

@rafecolton
Copy link
Owner

There are a couple places where the app code had to know about testing to prevent bad things from happening. This was also done to avoid putting the tests in the given package instead of the _test version.

However, requiring the application to know about the tests is bad. So that needs to be fixed.

This is done with the TestMode var in package job and webhook and with isRegular on the Builder struct. Likely, the whole code base needs to be audited for this pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant