You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a couple places where the app code had to know about testing to prevent bad things from happening. This was also done to avoid putting the tests in the given package instead of the _test version.
However, requiring the application to know about the tests is bad. So that needs to be fixed.
This is done with the TestMode var in package job and webhook and with isRegular on the Builder struct. Likely, the whole code base needs to be audited for this pattern.
The text was updated successfully, but these errors were encountered:
There are a couple places where the app code had to know about testing to prevent bad things from happening. This was also done to avoid putting the tests in the given package instead of the
_test
version.However, requiring the application to know about the tests is bad. So that needs to be fixed.
This is done with the
TestMode
var in package job and webhook and withisRegular
on theBuilder
struct. Likely, the whole code base needs to be audited for this pattern.The text was updated successfully, but these errors were encountered: