add a cyclic lookup #565
Merged
add a cyclic lookup #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 87.94% 88.11% +0.17%
==========================================
Files 40 40
Lines 3334 3383 +49
==========================================
+ Hits 2932 2981 +49
Misses 402 402
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Cycliclookup type that modifies selectors to cycle the lookup below and above its range.This works for
At,NearandContainsI'm not yet sure how to support
... It probably needs to return aVector{Int}but that would need special handling to have the correctOrderedunrolled cyclic lookup afterwards rather than just repeats of the cycle.