Breaking: include DataType in CategoricalEltypes #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
==========================================
+ Coverage 83.66% 84.64% +0.98%
==========================================
Files 47 50 +3
Lines 4653 4683 +30
==========================================
+ Hits 3893 3964 +71
+ Misses 760 719 -41 ☔ View full report in Codecov by Sentry. |
Oh no it's spreading 😂 But yes, great idea. Technically breaking I guess as it's changing the returned type, so let's lump this with another break |
rafaqz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin :)
Specifically designed to make using RasterDataSources climate types as lookups (as in rafaqz/Rasters.jl#826) even more slick.