New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix similar so that new memory is allocated #864

Merged

rafaqz merged 1 commit into rafaqz:main from ptiede:ptiede-similarfix

Nov 18, 2024

Contributor

ptiede commented Nov 18, 2024

This fixes #863 by allocating new memory in similar.
I also have added a test to ensure this is checked in future versions.


          Fix simliar to allocate new memory and add a test to ensure this.

2f00194

Owner

rafaqz commented Nov 18, 2024 •

edited

Loading

Good catch. We have far too many similar methods... But probably we need this check for every one

Looks like this was new from #844

rafaqz approved these changes

View reviewed changes

rafaqz merged commit 49b1b10 into rafaqz:main

7 of 8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet