Update purge test resources to fix the workflow failures #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytimocin
force-pushed
the
ytimocin/purgeWorkflowUpdate
branch
9 times, most recently
from
9e3ebf6 to
9ba20f7
Compare
lakshmimsft
reviewed
May 10, 2024
| jq -r '.[] | select(.creationTime == null || .creationTime < '$hours_ago') | .Name' resource_groups.json > ${{ env.AZURE_RG_DELETE_LIST_FILE}} | ||
| jq -r '.[] | {name: .Name, creationTime: .creationTime // "None"}' resource_groups.json > $GITHUB_STEP_SUMMARY | ||
| jq -r '.[] | select(.creationTime == null // (.creationTime | tonumber) < '$hours_ago') | .Name' resource_groups.json > ${{ env.AZURE_RG_DELETE_LIST_FILE}} | ||
| jq -r '.[] | "\(.Name) \(.creationTime // "None")"' resource_groups.json > $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
nit: comments might be helpful here. We made sure creationTime can be converted to a number and we're changing op format
There was a problem hiding this comment.
Added comments @lakshmimsft
lakshmimsft
reviewed
May 10, 2024
| @@ -40,8 +41,8 @@ jobs: | |||
| done | |||
|
|
|||
| - name: Create GitHub issue on failure | |||
| if: ${{ failure() }} | |||
| if: failure() && github.event_name == 'schedule' | |||
lakshmimsft
approved these changes
May 10, 2024
kachawla
reviewed
May 11, 2024
| @@ -40,8 +41,8 @@ jobs: | |||
| done | |||
|
|
|||
| - name: Create GitHub issue on failure | |||
| if: ${{ failure() }} | |||
| if: failure() && github.event_name == 'schedule' | |||
There was a problem hiding this comment.
Does this workflow run anywhere outside of scheduled runs?
There was a problem hiding this comment.
I add this to all workflows because I don't want issues to be created during pull requests. I spend a lot of time during some PRs 😁 Any suggestions? @kachawla
There was a problem hiding this comment.
What I'm trying to understand is, does this workflow run for PRs? :)
There was a problem hiding this comment.
I just double-checked and, no, it does not run for PRs. My bad. I will remove this now.
kachawla
reviewed
May 11, 2024
| @@ -22,13 +23,13 @@ jobs: | |||
| - name: List Test Resource Groups | |||
| run: | | |||
| echo "## Test resource group list" >> $GITHUB_STEP_SUMMARY | |||
| az group list --query "[?starts_with(name, 'samplestest-')].{Name:name, creationTime:tags.creationTime}" -o json > resource_groups.json | |||
| az group list --query "[?starts_with(name, 'rg-samplestest-')].{Name:name, creationTime:tags.creationTime}" -o json > resource_groups.json | |||
There was a problem hiding this comment.
What is causing this to change?
There was a problem hiding this comment.
I think it was wrong before. We can see that the resource groups we create have a prefix of rg-samplestest: https://github.com/radius-project/samples/blob/v0.33/.github/workflows/test.yaml#L122.
Signed-off-by: ytimocin <[email protected]>
ytimocin
force-pushed
the
ytimocin/purgeWorkflowUpdate
branch
from
9ba20f7 to
87690ee
Compare
rynowak
approved these changes
May 13, 2024
lakshmimsft
approved these changes
May 13, 2024
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
pushed a commit
that referenced
this pull request
May 23, 2024
Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]>
sk593
added a commit
that referenced
this pull request
May 23, 2024
* update gh to ado sync workflow to use service principals (#1363) * Make env configurable (#1046) Signed-off-by: Reshma Abdul Rahim <[email protected]> * Adding test AKS workflow to v0.32 (#1052) * Run functional tests every 2 hours and add another workflow that runs… (#1020) * Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d Signed-off-by: ytimocin <[email protected]> * Triggering workflow Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Removing the run of the AKS workflow on PRs (#1051) Signed-off-by: ytimocin <[email protected]> * Update the timeout (30s) for Playwright Signed-off-by: ytimocin <[email protected]> --------- Signed-off-by: ytimocin <[email protected]> * Use retry and update eshop playwright tests to wait for the catalog to appear (#1213) Signed-off-by: ytimocin <[email protected]> * update gh to ado sync workflow to use service principals Signed-off-by: Will Tsai <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Workflow and playwright test updates (#1360) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Changing the place of page.reload in the tests (#1492) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Adding a job that will purge AWS EKS clusters every 6 hours (#1462) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update all deps of all apps (#1536) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Updating the runner of purge azure test resources workflow (#1537) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Update purget test resources to fix the workflow failures (#1552) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> * Fixing the eShop catalog load issue for the UI tests (#1548) Signed-off-by: ytimocin <[email protected]> Signed-off-by: sk593 <[email protected]> --------- Signed-off-by: Reshma Abdul Rahim <[email protected]> Signed-off-by: ytimocin <[email protected]> Signed-off-by: Will Tsai <[email protected]> Signed-off-by: Will <[email protected]> Signed-off-by: sk593 <[email protected]> Co-authored-by: Will <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]> Co-authored-by: Yetkin Timocin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update purge test resources to fix the workflow failures