Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a EKS Purge Job, removing the AKS job, making the frequency once a day for test job #1462

Merged
merged 1 commit into from
May 1, 2024
Merged

Adding a EKS Purge Job, removing the AKS job, making the frequency once a day for test job #1462

merged 1 commit into from
May 1, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Apr 29, 2024 •
edited
Loading

  • Adding a job that will purge AWS EKS clusters once every day at 7 AM. The reasoning behind this is that the scheduled test job will run at 12 PM and the EKS Cluster will be already 7 hours old at the time purge job runs. So, if the cluster is not deleted, this job will clean the cluster and all of its underlying resources.
  • Removing the job that runs tests on the AKS Cluster.
  • Decreasing the schedule to once a day.

@ytimocin ytimocin requested a review from willdavsmith April 29, 2024 20:56
ytimocin
ytimocin commented Apr 29, 2024
View reviewed changes
.github/scripts/purge-aws-rds-snapshots.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat

ytimocin
ytimocin commented Apr 29, 2024
View reviewed changes
.github/workflows/purge-aws-rds-snapshots.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat

@ytimocin ytimocin force-pushed the ytimocin/addPurgeEKSJob branch 12 times, most recently from d68d978 to 13f6a7c Compare May 1, 2024 21:15
@ytimocin ytimocin changed the title Adding a job that will purge AWS EKS clusters every 6 hours Adding a EKS Purge Job, removing the AKS job, making the frequency once a day for test job May 1, 2024
@ytimocin ytimocin force-pushed the ytimocin/addPurgeEKSJob branch from 13f6a7c to 2d2d82d Compare May 1, 2024 21:31
rynowak
rynowak approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

.github/scripts/purge-aws-eks-clusters.sh
else
echo "Cluster $name is not older than 6 hours or does not meet naming criteria."
fi
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool 👍

@ytimocin ytimocin merged commit da710de into v0.33 May 1, 2024
8 checks passed
@ytimocin ytimocin deleted the ytimocin/addPurgeEKSJob branch May 1, 2024 22:07
sk593 pushed a commit that referenced this pull request May 23, 2024
@ytimocin @sk593
Adding a job that will purge AWS EKS clusters every 6 hours (#1462)
fb42ce7 
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>
sk593 pushed a commit that referenced this pull request May 23, 2024
@ytimocin @sk593
Adding a job that will purge AWS EKS clusters every 6 hours (#1462)
a320612 
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>
sk593 added a commit that referenced this pull request May 23, 2024
@sk593 @willtsai
@Reshrahim @ytimocin
Upmerge 0.33 to edge (#1563)
b9018d4 
* update gh to ado sync workflow to use service principals (#1363)

* Make env configurable (#1046)

Signed-off-by: Reshma Abdul Rahim <[email protected]>

* Adding test AKS workflow to v0.32 (#1052)

* Run functional tests every 2 hours and add another workflow that runs… (#1020)

* Run functional tests every 2 hours and add another workflow that runs the tests on AKS instead of k3d

Signed-off-by: ytimocin <[email protected]>

* Triggering workflow

Signed-off-by: ytimocin <[email protected]>

---------

Signed-off-by: ytimocin <[email protected]>

* Removing the run of the AKS workflow on PRs (#1051)

Signed-off-by: ytimocin <[email protected]>

* Update the timeout (30s) for Playwright

Signed-off-by: ytimocin <[email protected]>

---------

Signed-off-by: ytimocin <[email protected]>

* Use retry and update eshop playwright tests to wait for the catalog to appear (#1213)

Signed-off-by: ytimocin <[email protected]>

* update gh to ado sync workflow to use service principals

Signed-off-by: Will Tsai <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: Will <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Yetkin Timocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Workflow and playwright test updates (#1360)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Changing the place of page.reload in the tests (#1492)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Adding a job that will purge AWS EKS clusters every 6 hours (#1462)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Update all deps of all apps (#1536)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Updating the runner of purge azure test resources workflow (#1537)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Update purget test resources to fix the workflow failures (#1552)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

* Fixing the eShop catalog load issue for the UI tests (#1548)

Signed-off-by: ytimocin <[email protected]>
Signed-off-by: sk593 <[email protected]>

---------

Signed-off-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: ytimocin <[email protected]>
Signed-off-by: Will Tsai <[email protected]>
Signed-off-by: Will <[email protected]>
Signed-off-by: sk593 <[email protected]>
Co-authored-by: Will <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Co-authored-by: Yetkin Timocin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdavsmith willdavsmith willdavsmith approved these changes

@rynowak rynowak rynowak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ytimocin @rynowak @willdavsmith