Update envoy base image #441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,9 +6,9 @@ What this means is that if we need to update the names of routes in eshop, *we l | |||
|
|
|||
| The routing configuration is in [envoy.yaml](envoy.yaml). See the `route_config` section specifically. | |||
|
|
|||
| To build the docker image, run `docker build . -t radius.azurecr.io/eshop-envoy:0.1.<NUMBER>`. | |||
| To build the docker image, run `docker build . -t radius.azurecr.io/eshop-envoy:<TAG>`. | |||
|
|
|||
| Where NUMBER is one greater than the latest version made. To view versions, see https://ms.portal.azure.com/#view/Microsoft_Azure_ContainerRegistries/RepositoryBlade/id/%2Fsubscriptions%2F66d1209e-1382-45d3-99bb-650e6bf63fc0%2FresourceGroups%2Fassets%2Fproviders%2FMicrosoft.ContainerRegistry%2Fregistries%2Fradius/repository/eshop-envoy. | |||
There was a problem hiding this comment.
If we're no longer using NUMBER should we remove these instructions?
| @@ -119,7 +119,7 @@ resource webshoppingapigw 'Applications.Core/containers@2022-03-15-privateprevie | |||
| properties: { | |||
| application: application | |||
| container: { | |||
| image: 'radius.azurecr.io/eshop-envoy:0.1.4' | |||
| image: 'radius.azurecr.io/eshop-envoy:v1.27-latest' | |||
There was a problem hiding this comment.
Do we want this tag to match the base image?
|
@willdavsmith -- is this still needed? Please either address @AaronCrawfis comments or else close out this PR. Thanks! |
|
Closing this as stale. @willdavsmith please reopen if there's something to do. |
|
closing in favor of: #2002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #813