Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate bicep files step fails for all PRs #43

Closed
ytimocin opened this issue Aug 9, 2022 · 2 comments
Closed

Validate bicep files step fails for all PRs #43

ytimocin opened this issue Aug 9, 2022 · 2 comments

Comments

@ytimocin
Copy link
Contributor

ytimocin commented Aug 9, 2022

Example: https://github.com/project-radius/samples/runs/7750855245

The bicep files that fail are under eshop/iac folder. If this is the expected behavior, then we should disable validating bicep files step.

@emily-potyraj
Copy link

emily-potyraj commented Aug 11, 2022

triage note: not a blocker for v0.12 since we can still ship our samples in the current state.
@AaronCrawfis can you please help take a look here? thanks

@ytimocin is this failing only for the eShop reference app or is it blocking images for other sample apps?

@AaronCrawfis
Copy link
Contributor

This is due to the eShop PR still being open. Will be resolved by #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants