Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signoff to Upmerge samples to edge workflow #1884

Closed
willdavsmith opened this issue Nov 8, 2024 · 3 comments · Fixed by #1889
Closed

Add signoff to Upmerge samples to edge workflow #1884

willdavsmith opened this issue Nov 8, 2024 · 3 comments · Fixed by #1889
Assignees
@willdavsmith @brooke-hamilton
Labels
bug Something is broken or not working as expected on-call triaged This item has been triaged by project maintainers and is in the backlog

Comments

@willdavsmith
Copy link
Contributor

willdavsmith commented Nov 8, 2024 •
edited by azure-boards bot
Loading

The Upmerge samples to edge workflow does not include a signoff message in the commit:

samples/.github/workflows/upmerge.yaml

Line 65 in f92e009

git merge -m "Upmerge to edge" origin/$SOURCE_BRANCH

This causes DCO to fail during the release process. We should add a signoff flag to the git merge command.

AB#13662
@willdavsmith willdavsmith added the bug Something is broken or not working as expected label Nov 8, 2024
@willdavsmith willdavsmith self-assigned this Nov 8, 2024
@willdavsmith willdavsmith mentioned this issue Nov 8, 2024
Merged
6 tasks
@ytimocin ytimocin added the triaged This item has been triaged by project maintainers and is in the backlog label Nov 11, 2024
@ytimocin
Copy link
Contributor

Closing this now @willdavsmith. You can re-open if it is not fixed already.

@kachawla
Copy link
Contributor

This hasn't been fixed yet, re-opening and removing triage label.

@kachawla kachawla reopened this Nov 22, 2024
@kachawla kachawla removed the triaged This item has been triaged by project maintainers and is in the backlog label Nov 22, 2024
@ytimocin ytimocin added triaged This item has been triaged by project maintainers and is in the backlog on-call labels Nov 25, 2024
@brooke-hamilton
Copy link
Contributor

/assign

@brooke-hamilton brooke-hamilton mentioned this issue Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdavsmith willdavsmith

@brooke-hamilton brooke-hamilton

Labels
bug Something is broken or not working as expected on-call triaged This item has been triaged by project maintainers and is in the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add git signoff to the commit in the upmerge workflow brooke-hamilton/radius-samples
4 participants
@ytimocin @willdavsmith @brooke-hamilton @kachawla