diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 272810c1..9e055d42 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -20,9 +20,7 @@ env: VERSION: ${{ github.event.pull_request.number || 'latest' }} # Use ghcr.io/radius-project/dev for PR build. Otherwise, use ghcr.io/radius-project. CONTAINER_REGISTRY: ${{ github.event.pull_request.number && 'ghcr.io/radius-project/dev' || 'ghcr.io/radius-project' }} - # Set to true to push images to registry. - PUSH_IMAGE: true - + jobs: build-ghcr: name: Build and push sample images to GHCR @@ -60,5 +58,5 @@ jobs: uses: docker/build-push-action@v4 with: context: ./${{ matrix.directory }} - push: ${{ env.PUSH_IMAGE }} + push: ${{ github.event_name == 'push' && true || false }} tags: ${{ env.CONTAINER_REGISTRY }}/${{ matrix.image }}:${{ env.VERSION }} diff --git a/.github/workflows/validate-bicep.yaml b/.github/workflows/validate-bicep.yaml index 0e53d6fa..14e817d7 100644 --- a/.github/workflows/validate-bicep.yaml +++ b/.github/workflows/validate-bicep.yaml @@ -31,12 +31,6 @@ jobs: steps: - name: Check out repo uses: actions/checkout@v2 - - name: az CLI login - run: | - az login --service-principal \ - --username ${{ secrets.AZURE_SP_TESTS_APPID }} \ - --password ${{ secrets.AZURE_SP_TESTS_PASSWORD }} \ - --tenant ${{ secrets.AZURE_SP_TESTS_TENANTID }} - name: Parse release version and set environment variables run: python ./.github/scripts/get_docs_version.py - name: Download rad-bicep