From 17e94a7d9a34ae36ee2c30f654c8d124fde0cd7d Mon Sep 17 00:00:00 2001 From: willdavsmith Date: Tue, 12 Sep 2023 12:18:25 -0700 Subject: [PATCH] I think it works --- .github/workflows/test.yaml | 14 ++++++++------ ui-tests/deleted-resources.txt | 0 2 files changed, 8 insertions(+), 6 deletions(-) delete mode 100644 ui-tests/deleted-resources.txt diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9406fa8d..b7c21443 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -63,11 +63,11 @@ jobs: runOnPullRequest: true app: eshop path: ./reference-apps/eshop/iac/eshop.bicep - args: -p appName eshop + args: -p appName=eshop uiTestFile: tests/eshop/container.app.spec.ts enableDapr: false - name: eshop-azure - runOnPullRequest: true #false + runOnPullRequest: false app: eshop-azure path: ./reference-apps/eshop/iac/eshop.bicep args: -p platform=azure -p appName=eshop-azure @@ -75,7 +75,7 @@ jobs: credential: azure enableDapr: false - name: eshop-aws - runOnPullRequest: true #false + runOnPullRequest: false app: eshop-aws-${{ github.run_id }}-${{ github.run_attempt }} path: ./reference-apps/eshop/iac/eshop.bicep args: -p platform=aws -p eksClusterName=eks-samplestest-${{ github.run_id }}-${{ github.run_attempt }}-eshop-aws -p appName=eshop-aws-${{ github.run_id }}-${{ github.run_attempt }} @@ -249,9 +249,11 @@ jobs: cd ui-tests/ npm ci npx playwright install --with-deps - endpoint=$(rad app status -o json -a ${{ matrix.app }} | sed 's/ /\n/g' | grep http) - echo $endpoint - export ENDPOINT=$endpoint + if [[ "${{ matrix.container }}" != "" ]]; then + endpoint=$(rad app status -o json -a ${{ matrix.app }} | sed 's/ /\n/g' | grep http) + echo $endpoint + export ENDPOINT=$endpoint + fi npx playwright test ${{ matrix.uiTestFile }} --retries 3 - name: Upload Playwright Results uses: actions/upload-artifact@v3 diff --git a/ui-tests/deleted-resources.txt b/ui-tests/deleted-resources.txt deleted file mode 100644 index e69de29b..00000000